Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Make the Workspace UI element more distinguishable #6576

Merged
merged 19 commits into from
Oct 23, 2024
Merged

🎨 [Frontend] Make the Workspace UI element more distinguishable #6576

merged 19 commits into from
Oct 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 22, 2024 •
edited
Loading

What do these changes do?

We still don't have a view where Workspaces and Studies are listed together, but this might change when the Recycle Bin feature comes in.

In order to make them a bit more distinguishable, this PR changes a bit the aesthetics of the Workspace element:

  • The shape of the element is folder-like
  • The header has the same background color as the body with a bit of a transparency

Workspaces
image

Studies
image

Folders
image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 22, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 22, 2024
@odeimaiz odeimaiz self-assigned this Oct 22, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 23, 2024 09:49
@odeimaiz odeimaiz enabled auto-merge (squash) October 23, 2024 09:50
matusdrobuliak66
matusdrobuliak66 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pcrespov
pcrespov reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz merged commit adac8d0 into ITISFoundation:master Oct 23, 2024
51 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 24, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] Make the Workspace UI element more distinguishable (ITIS…
6fccbee 
…Foundation#6576)
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @ignapas @pcrespov @matusdrobuliak66